Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fdc3) - Fixing flaky DesktopAgent tests #537

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Mar 7, 2024

Changes:

  • Added pendingStartRequests collection to store the started module's vis raiseIntent call and wait for them to actually start before attempting to raiseIntent.

@lilla28 lilla28 requested a review from a team as a code owner March 7, 2024 08:24
@lilla28 lilla28 marked this pull request as draft March 7, 2024 08:48
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (9305d5d) to head (f4f0d6e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          45       45           
  Lines        2359     2359           
  Branches      299      239   -60     
=======================================
  Hits         2126     2126           
- Misses        229      232    +3     
+ Partials        4        1    -3     

see 3 files with indirect coverage changes

@lilla28 lilla28 marked this pull request as ready for review March 7, 2024 09:11
@lilla28 lilla28 marked this pull request as draft March 7, 2024 09:12
bingenito
bingenito previously approved these changes Mar 8, 2024
@lilla28 lilla28 force-pushed the skip/da-channel-test branch 3 times, most recently from b3f04f8 to 5131633 Compare March 14, 2024 09:47
@lilla28 lilla28 marked this pull request as ready for review March 14, 2024 12:34
@lilla28 lilla28 changed the title fix(fdc3) - Skippng StoreIntent_succeeds_with_channel test as it's flaky fix(fdc3) - Fixing flaky DesktopAgent tests Mar 14, 2024
@lilla28 lilla28 force-pushed the skip/da-channel-test branch 4 times, most recently from ec0b52b to f263521 Compare March 18, 2024 13:54
@lilla28 lilla28 merged commit fc51baa into morganstanley:main Mar 19, 2024
5 checks passed
ZKRobi pushed a commit to ZKRobi/ComposeUI that referenced this pull request Mar 22, 2024
kruplm pushed a commit that referenced this pull request Apr 10, 2024
@lilla28 lilla28 deleted the skip/da-channel-test branch May 15, 2024 10:05
lilla28 added a commit to lilla28/ComposeUI that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants