Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdc3 e2e test #754

Merged

Conversation

agyen
Copy link
Contributor

@agyen agyen commented Aug 27, 2024

Automated test for displaying pricing data and opening chart using sikuli

@agyen agyen requested a review from a team as a code owner August 27, 2024 09:20
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.04%. Comparing base (dd3817e) to head (83879ca).
Report is 30 commits behind head on feat-sikuli-e2e-ui-tests.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feat-sikuli-e2e-ui-tests     #754      +/-   ##
============================================================
+ Coverage                     67.63%   69.04%   +1.40%     
============================================================
  Files                           261      292      +31     
  Lines                          7997     8676     +679     
  Branches                        894      929      +35     
============================================================
+ Hits                           5409     5990     +581     
- Misses                         2400     2467      +67     
- Partials                        188      219      +31     

see 55 files with indirect coverage changes

@ZKRobi
Copy link
Contributor

ZKRobi commented Aug 27, 2024

Could you add a readme explaining prerequisites and instructions on running the tests?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ZKRobi ZKRobi self-requested a review September 3, 2024 07:37
ZKRobi
ZKRobi previously approved these changes Sep 3, 2024
lilla28
lilla28 previously approved these changes Sep 4, 2024
@agyen agyen dismissed stale reviews from lilla28 and ZKRobi via 724d927 September 6, 2024 09:29
@kruplm kruplm changed the base branch from main to feat-sikuli-e2e-ui-tests September 10, 2024 11:45
@ZKRobi ZKRobi self-requested a review September 10, 2024 11:52
@kruplm kruplm merged commit af89a6f into morganstanley:feat-sikuli-e2e-ui-tests Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants