Enable Leak Sanitizer and Undefined Behavior Sanitizer #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ASAN_OPTION envvar is also inherited by child tests launched by the IntegrationTest process and takes effect (verified manually by adding new int(1) to Logging.cpp). If the project is not compiled with ASAN, the extra envvar is harmless.
Run UBSAN next to ASAN in GitHub ci. cmake/UndefinedSanitizer.cmake The cmake check_cxx_compiler_flag seems to use a test that compiles with -fsanitized=undefined only, even if the platform also requires a statically linked ubsan lib: Prefer the statically linked lib, if available. include/mserialize/detail/integer_to_hex.hpp Only with ubsan, the changed code is rejected by GCC, as shown in the comment. Perhaps a bug?
| @@ -297,6 +299,7 @@ if(Boost_FOUND) | |||
|
|
|||
| add_test(NAME IntegrationTest | |||
| COMMAND IntegrationTest --log_level=test_suite --color_output=true -- "$<TARGET_FILE:bread>" "$<TARGET_FILE_DIR:IntegrationTest>" "${PROJECT_SOURCE_DIR}") | |||
| set_property(TEST IntegrationTest PROPERTY ENVIRONMENT ASAN_OPTIONS=detect_leaks=1) | |||
There was a problem hiding this comment.
andrewkcorcoran
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details. Fixes #39