Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aaveV3): adapt to pool data provider upgrade #111

Closed
wants to merge 6 commits into from

Conversation

oumar-fall
Copy link
Contributor

@oumar-fall oumar-fall commented Oct 10, 2024

Description of change

Updated test to run on more recent block since aave changed their contracts

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@oumar-fall oumar-fall self-assigned this Oct 10, 2024
@oumar-fall oumar-fall force-pushed the fix/pool-data-provider-upgrade branch from 8797ec5 to 05e9c65 Compare October 10, 2024 13:43
@oumar-fall oumar-fall force-pushed the fix/pool-data-provider-upgrade branch from 05e9c65 to 04c17a4 Compare October 17, 2024 09:50
@oumar-fall oumar-fall requested a review from Rubilmax October 17, 2024 09:50
tests/units/blockTag.test.ts Outdated Show resolved Hide resolved
@@ -284,27 +284,22 @@ describe("MorphoAaveV3", () => {
TransactionType.borrow
)!;

// Let's now borrow all the liquidity we can
// Let's now borrow 90% of borrow capacity

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it's an IRM overflow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise tests fail because of a rounding issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants