-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move to lerna monorepo #452
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
force-pushed
the
refactor/monorepo-2
branch
from
September 27, 2024 09:37
2a6562a
to
dbe44f9
Compare
julien-devatom
previously approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config is only used for testing right? Wdyt about naming it "test-config"? Find it cleaner
adhusson
reviewed
Sep 27, 2024
adhusson
reviewed
Sep 27, 2024
adhusson
previously approved these changes
Sep 27, 2024
julien-devatom
previously approved these changes
Sep 27, 2024
Rubilmax
dismissed stale reviews from julien-devatom and adhusson
via
September 27, 2024 13:03
698bd16
adhusson
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are required to move to a monorepo to be able to port the ethers encoding SDK to viem and maintain both at the same time
Hardhat's compilation in packages is hacky: it uses symbolic links of root
src
to localcontracts
. But it works!