Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move to lerna monorepo #452

Closed
wants to merge 6 commits into from
Closed

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax commented Sep 27, 2024

We are required to move to a monorepo to be able to port the ethers encoding SDK to viem and maintain both at the same time

Hardhat's compilation in packages is hacky: it uses symbolic links of root src to local contracts. But it works!

@Rubilmax Rubilmax self-assigned this Sep 27, 2024
julien-devatom
julien-devatom previously approved these changes Sep 27, 2024
Copy link
Contributor

@julien-devatom julien-devatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config is only used for testing right? Wdyt about naming it "test-config"? Find it cleaner

biome.json Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
hardhat.config.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/ethers/package.json Show resolved Hide resolved
adhusson
adhusson previously approved these changes Sep 27, 2024
julien-devatom
julien-devatom previously approved these changes Sep 27, 2024
@Rubilmax Rubilmax closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants