Cantina review #572
Merged
Cantina review #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Co-authored-by: MathisGD <74971347+MathisGD@users.noreply.github.com> Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Co-authored-by: MathisGD <74971347+MathisGD@users.noreply.github.com> Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Rename expected balance for assets
…to fix/document-conversions-63
…to fix/missing-natspecs-15
Document possible conversion reverts
Funds could be stuck if IRM reverts
Add public accrue interest function
…to fix/missing-natspecs-15
Refactor interfaces
…to fix/missing-natspecs-15
Add some missing comment
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
`UtilsLib.zeroFloorSub` is not utilised consistently
Update `cantina-review`
Signature of `idToMarketParams` to return a struct
Remove IRM call skip
MathisGD
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.