Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update halmos tests for new version #692

Merged
merged 4 commits into from
Sep 27, 2024
Merged

test: update halmos tests for new version #692

merged 4 commits into from
Sep 27, 2024

Conversation

daejunpark
Copy link
Contributor

@daejunpark daejunpark commented Sep 27, 2024 •
edited
Loading

this updates halmos tests for the new version.

changes:

  • replaced --symbolic-storage with enableSymbolicStorage() cheatcode
  • explicitly updated the block number and timestamp
  • fixed and improved calldata generation for flashLoan()

daejunpark
daejunpark commented Sep 27, 2024
View reviewed changes
test/halmos/HalmosTest.sol Show resolved Hide resolved
test/halmos/HalmosTest.sol Show resolved Hide resolved
test/halmos/HalmosTest.sol Show resolved Hide resolved
test/halmos/HalmosTest.sol Show resolved Hide resolved
test/halmos/HalmosTest.sol Show resolved Hide resolved
test/halmos/HalmosTest.sol Show resolved Hide resolved
test/halmos/HalmosTest.sol Show resolved Hide resolved
@daejunpark daejunpark marked this pull request as ready for review September 27, 2024 04:31
@QGarchery QGarchery mentioned this pull request Sep 27, 2024
Closed
@QGarchery QGarchery self-assigned this Sep 27, 2024
@QGarchery QGarchery added the verif Modifies the formal verification label Sep 27, 2024
@QGarchery QGarchery mentioned this pull request Sep 27, 2024
Merged
@daejunpark daejunpark mentioned this pull request Sep 27, 2024
Merged
@MathisGD
Copy link
Contributor

Thanks for your update! @daejunpark

@MathisGD MathisGD merged commit dee266f into morpho-org:main Sep 27, 2024
5 of 16 checks passed
@daejunpark daejunpark deleted the halmos/update-v2 branch September 28, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@QGarchery QGarchery QGarchery approved these changes

Assignees

@QGarchery QGarchery

Labels
verif Modifies the formal verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daejunpark @MathisGD @QGarchery