Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license warning #707

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix license warning #707

merged 1 commit into from
Dec 2, 2024

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Nov 30, 2024

Looking into it it seems like the warning comes from:

However spdx-license-ids only added BUSL-1.1 at version 3.0.7, see here. So it seems like it's not required for yarn to use the version that includes the BUSL-1.1 identifier.

In any case, fixing it would require an update of yarn, but they seem to not accept any PR on version 1 now, unless it's fixing a critical vulnerability.

Instead I propose to bypass the check of yarn, as allowed here. And for morpho-blue it feels like it makes sense because there is a dual license BUSL + GPL

@MathisGD MathisGD merged commit a4210e9 into main Dec 2, 2024
17 checks passed
@MathisGD MathisGD deleted the fix/license-warning branch December 2, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants