-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rounding in test #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should increase the fuzz runs in the CI ?
Yes, I'm trying to see how much is enough |
What's the max number of fuzz runs we can possibly set ? |
Don't know but it will be slow and your computer will be running super hot |
I'm working on another big test refactoring PR and I was also fixing various rounding issues, including your fixes in my PR would be better imo |
Replaced by #74 |
was making tests fail locally for me (still disappointed by the inconsistency of the forge fuzzer, because apparently on GitHub everything was fine)