Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner => admin #30

Merged
merged 19 commits into from
Mar 5, 2024
Merged

owner => admin #30

merged 19 commits into from
Mar 5, 2024

Conversation

MathisGD
Copy link
Contributor

Rubilmax
Rubilmax previously approved these changes Feb 29, 2024
QGarchery
QGarchery previously approved these changes Feb 29, 2024
src/PublicAllocator.sol Outdated Show resolved Hide resolved
src/libraries/EventsLib.sol Outdated Show resolved Hide resolved
src/libraries/EventsLib.sol Outdated Show resolved Hide resolved
src/libraries/EventsLib.sol Outdated Show resolved Hide resolved
src/libraries/EventsLib.sol Outdated Show resolved Hide resolved
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
@MathisGD MathisGD dismissed stale reviews from QGarchery and Rubilmax via c575b0b February 29, 2024 13:11
QGarchery
QGarchery previously approved these changes Feb 29, 2024
MerlinEgalite
MerlinEgalite previously approved these changes Feb 29, 2024
src/PublicAllocator.sol Show resolved Hide resolved
src/PublicAllocator.sol Outdated Show resolved Hide resolved
src/PublicAllocator.sol Outdated Show resolved Hide resolved
adhusson and others added 3 commits February 29, 2024 15:33
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com>
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
@MathisGD MathisGD dismissed stale reviews from MerlinEgalite and QGarchery via e0e5905 February 29, 2024 14:55
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
QGarchery
QGarchery previously approved these changes Feb 29, 2024
Rubilmax
Rubilmax previously approved these changes Feb 29, 2024
MathisGD and others added 2 commits February 29, 2024 17:59
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
adhusson
adhusson previously approved these changes Feb 29, 2024
QGarchery
QGarchery previously approved these changes Feb 29, 2024
@QGarchery
Copy link
Contributor

One change missing though to compile

@MathisGD MathisGD dismissed stale reviews from QGarchery and adhusson via 1192899 February 29, 2024 19:02
adhusson
adhusson previously approved these changes Feb 29, 2024
Jean-Grimal
Jean-Grimal previously approved these changes Mar 1, 2024
Rubilmax
Rubilmax previously approved these changes Mar 1, 2024
MerlinEgalite
MerlinEgalite previously approved these changes Mar 1, 2024
test/PublicAllocatorTest.sol Show resolved Hide resolved
QGarchery
QGarchery previously approved these changes Mar 1, 2024
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
@MathisGD MathisGD merged commit 14f37ed into main Mar 5, 2024
2 checks passed
@MathisGD MathisGD deleted the style/owner-naming branch March 5, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants