Fixup for stale kickoff removal in wireless regulator API #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeny-boger
added a commit
to wirenboard/rtl8733bu
that referenced
this pull request
Nov 19, 2023
|
Sorry I did not pinged you a week after your request to do so. Could this merge request be merged? |
sikmir
pushed a commit
to wirenboard/rtl8733bu
that referenced
this pull request
Apr 10, 2024
sikmir
pushed a commit
to wirenboard/rtl8733bu
that referenced
this pull request
Apr 11, 2024
|
Hi @prahal Sorry about the delay. I have had some real challenges over the last year. Let's get this taken care of. Right now I see a conflict caused by a change that the RHEL maintainer made since you sent this patch: #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 19, 0)) && (LINUX_VERSION_CODE < KERNEL_VERSION(6, 1, 39)) && !defined(RHEL94) Can I get you to look at this and propose a solution? |
Cope with the fix in stable 6.3.13 commit bf353116d1bf, 6.5-rc1 commte8c2af660ba0 and and 6.1.39 commit 132b7129c5fe LTS "wifi: cfg80211: fix regulatory disconnect with OCB/NAN". That is the removal of REGULATORY_IGNORE_STALE_KICKOFF from the wireless regulator internal API to fix any driver that allowed OCB/NAN.
prahal
force-pushed
the
complete-fixup-for-wifi-api-removal
branch
from
aa3e383
to
db69d76
Compare
|
Done. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cope with the fix in stable 6.3.13 commit bf353116d1bf, 6.5-rc1 commte8c2af660ba0 and and 6.1.39 commit 132b7129c5fe LTS "wifi: cfg80211: fix regulatory disconnect with OCB/NAN". That is the removal of REGULATORY_IGNORE_STALE_KICKOFF from the wireless regulator internal API to fix any driver that allowed OCB/NAN.
I made this patch for the compilation error: wiphy->regulatory_flags |= REGULATORY_IGNORE_STALE_KICKOFF.
It was included and expanded in armbian https://github.com/armbian/build/blob/84e4a26bb09e9bc8401d3768c8158782ea601fc4/patch/misc/wireless-rtl88x2bu-wireless-ignore-stale-kickoff-removal.patch
The issue was this API change fixup was backported to stable/lts branches of the kernel.
This patch copes with this API change backports in al known branches it was included in, that
is in 6.1, 6.3, and 6.4 and above.
THis is for completeness as the current code which treat all kernel below 6.1.39 as including this API change will only break if one attempts to build an older tag of the 6.3 and 6.4 branches (or if one try to build the 6.2 branch). Most likely if one does regression testing. So the code already works in most cases.
Closes issue #165