Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement persisting UI states #294

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tech-bash
Copy link

@tech-bash tech-bash commented Aug 9, 2023

Fix: #140

I have started the task, please let me know if I am going in the right direction. Just for my check the moveEvent doesn't have any size() function it has QPoint so to avoid the implications I set them_savedSize type to QVariant would that be okay?

Signed-off-by: Bhavy Airi <airiragahv@gmail.com>
@tech-bash
Copy link
Author

@mortbopet any comments sir?

Copy link
Owner

@mortbopet mortbopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's a need to store the size and state in in-memory variables. Instead, you should call RipesSettings::setValue within the events.
Secondly, there's two parts to UI state persistence - one is storing the current state whenever it changes, the other is that you need to load said state upon program startup (i suggest that you analyse some of the other usages of RipesSettings throughout the codebase to get a feel for this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persisting UI state between program invocations
2 participants