Add option to shift noise schedules when changing resolution #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazcollins
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
I had one qq about why we choose base_dim=32 as default. I also wish we could infer the shift resolution from some other place (instead of having to set it explicitly, bc I can imagine forgetting to set that in an eval run and using the wrong resolution or something) but I don't see how that is possible, so this makes sense! Overall looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to set
scheduler_shift_resolutionto SD2 and SDXL models to account for differing train resolutions using the technique from https://arxiv.org/abs/2301.11093