Critical code review PR - Last sprint handover checklist of 0.2.0 release

.github/workflows/android-publish.yml → .github/workflows/publish-maven-npm.yml

@@ -1,12 +1,12 @@
-name: Android Artifact Publish
+name: Artifacts Publish
 
 on:
   workflow_dispatch:
     inputs:
       message:
         description: 'Message for manually triggering'
         required: false
-        default: 'Triggered for inji-vc-client Updates'
+        default: 'Triggered for inji-vci-client Updates'
         type: string
 
 jobs:
@@ -16,10 +16,12 @@ jobs:
       SERVICE_LOCATION: 'kotlin'
       ANDROID_SERVICE_LOCATION: 'vci-client'
       JAVA_VERSION: 21
+      LICENSE_NAME: 'MPL-2.0'
     secrets:
       OSSRH_USER: ${{ secrets.OSSRH_USER }}
       OSSRH_URL: ${{secrets.OSSRH_SNAPSHOT_URL }}
       OSSRH_SECRET: ${{ secrets.OSSRH_SECRET }}
       OSSRH_TOKEN: ${{ secrets.OSSRH_TOKEN }}
       GPG_SECRET: ${{ secrets.GPG_SECRET }}
-      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_INJI_TEAM }}
+      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_INJI_TEAM }}
+

.github/workflows/push-trigger.yml

@@ -17,36 +17,20 @@ on:
 
 jobs:
   build-kotlin:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Set up JDK 21
-        uses: actions/setup-java@v3
-        with:
-          distribution: adopt
-          java-version: 21
-          server-id: ossrh
-          settings-path: ${{ github.workspace }}
-
-      - name: Cache Gradle packages
-        uses: actions/cache@v3.3.1
-        with:
-          path: |
-            ~/.gradle/caches
-            ~/.gradle/wrapper
-          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
-          restore-keys: ${{ runner.os }}-gradle-
-
-      - uses: actions/checkout@v3.1.0
-      - name: Run tests
-        run: |
-          cd kotlin
-          ./gradlew test
-
-      - uses: 8398a7/action-slack@v3
-        with:
-          status: ${{ job.status }}
-          fields: repo,message,author,commit,workflow,job 
-        env:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_INJI_TEAM }}
-        if: "${{ github.event_name != 'pull_request' && failure() }}"
+    uses: mosip/kattu/.github/workflows/gradle-build.yml@master
+    with:
+      SERVICE_LOCATION: kotlin
+      JAVA_VERSION: 17
+    secrets:
+      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_INJI_TEAM }}
 
+  sonar_analysis:
+    needs: build-kotlin
+    if: "${{  github.event_name != 'pull_request' }}"
+    uses: mosip/kattu/.github/workflows/gradlew-sonar-analysis.yml@master-java21
+    with:
+      SERVICE_LOCATION: kotlin/vci-client
+    secrets:
+      SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+      SONAR_ORGANIZATION: ${{ secrets.ORG_KEY }}
+      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_INJI_TEAM }}

.talismanrc

@@ -14,7 +14,7 @@ fileignoreconfig:
 - filename: .github/workflows/android-publish.yml
   checksum: edbd3e2d8abebe83505f7dd14a6a21cc6ef5ee7cffc0dfe1db105aee88447a31
 - filename: kotlin/vci-client/publish-artifact.gradle
-  checksum: 0fd8f7b02c302182c4b4ad1a6ef77f31d5f6e0b560cf1d6c10d8dcb16a4600d9
+  checksum: 565f2e26585bd759839ec41a3945e800746ac37f827bb1c539097be34e82bdc6
 - filename: kotlin/vci-client/src/test/java/io/mosip/vciclient/proof/jwt/JWTProofHeaderTest.kt
   checksum: c484c29e5599b1191c54be3585299015a5cdabc8fe8e9bc7eb158cbfbc01d831
 - filename: kotlin/vci-client/src/test/java/io/mosip/vciclient/VCIClientTest.kt
@@ -28,5 +28,13 @@ fileignoreconfig:
 - filename: kotlin/readme.md
   checksum: fa94864a42be5559b42c00cfde2e8c9fc20e966dc96df8cfeac468843abf10ed
 - filename: .github/workflows/push-trigger.yml
-  checksum: 34101f249b8fd7794a845193b1b5075111df56efa2e39e670302c6110e6444fa
+  checksum: 0be23c82aeb8f6746b200645f64b4df81384ab7a61214b805607d0d2e2a35649
+- filename: js/yarn.lock
+  checksum: 93ff5a7a86aca9331789ba087c0288bfce3c708259bc178cc00cb0d347cffd6d
+- filename: js/package-lock.json
+  checksum: a092082d3929fedf476a9cbfed346b1f52f78353440f70c932488379dd2637d0
+- filename: js/example/package-lock.json
+  checksum: 5f658cf32ba71bd5664c1dfd2fd09113f62abdd50ac4682ad4c320e09f783942
+- filename: .github/workflows/publish-maven-npm.yml
+  checksum: 5f43cf25702e703658b0cc0a38ec6089631b3e8e86bd4a923658536389cf296d
 version: ""