Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ctx for lock and unlock interface #1022

Merged
merged 36 commits into from
Dec 11, 2023
Merged

feat: Add ctx for lock and unlock interface #1022

merged 36 commits into from
Dec 11, 2023

Conversation

wenxuwan
Copy link
Member

What this PR does:

Add ctx for lock and unlock interface

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


add contentlenth

fix version

remove unused changes

remove blank

remove blank
Copy link

Hi @wenxuwan. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45d0793) 62.47% compared to head (c1c3fb7) 62.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1022   +/-   ##
=======================================
  Coverage   62.47%   62.47%           
=======================================
  Files         154      154           
  Lines       10459    10459           
=======================================
  Hits         6534     6534           
  Misses       3108     3108           
  Partials      817      817           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenxuwan wenxuwan requested a review from ZLBer December 11, 2023 08:29
Copy link
Contributor

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenxuwan wenxuwan merged commit 94fc2ed into mosn:main Dec 11, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants