Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change getobject default size from 100kb to 1M #1067

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

wenxuwan
Copy link
Member

What this PR does:

Because there is a performance loss in the serialization of prtobuf, in order to reduce the performance loss of grpc in the oss scenario, the data size of each file transfer is increased to reduce the number of transmissions.

Copy link

Hi @wenxuwan. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

Copy link
Contributor

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wenxuwan wenxuwan merged commit 9db2aa0 into mosn:main Sep 19, 2024
25 checks passed
@wenxuwan wenxuwan deleted the fix_oss_performance branch September 19, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants