feat: support nacos configstore component (level1) #939

cyb0225 · 2023-06-07T16:52:45Z

What this PR does:

support nacos configstore component with level1.

Which issue(s) this PR fixes: #921

Fixes #

Special notes for your reviewer:

参考文档： https://mosn.io/layotto/#/zh/design/configuration/configuration-api-with-apollo

目前的 mock 采用的是 gomock 生成，并未实际模拟 nacos 配置中心的行为，只是对测试输入和结果进行预定义，只针对个人编写代码进行了测试（比如参数校验，分支预测等）

情况完成

完成：

level1 模式的配置中心功能
单元测试
完善连接 nacos 配置的方式。（支持连接自建 nacos 服务，以及连接阿里云 nacos 服务）
分页操作。

未完成：

相关文档

Does this PR introduce a user-facing change?:

github-actions · 2023-06-07T16:53:17Z

Hi @cyb0225. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

…ening configs.

… delete that config key.

…ng literals.

…nic.

…igs.

support level1 config functions. support connect to nacos use acm mode. fix error in filling in illegal characters when calling nacos set and delete parameters

cyb0225 · 2023-06-16T04:29:02Z

@wenxuwan, 大致功能已经做完了，你看看。还剩下几个地方可能需要再讨论一下。

codecov · 2023-06-16T04:37:22Z

Codecov Report

Patch coverage: 79.04% and project coverage change: +0.65 🎉

Comparison is base (8f2c52f) 59.80% compared to head (e16a6d4) 60.45%.

❗ Current head e16a6d4 differs from pull request most recent head aa6d958. Consider uploading reports for the commit aa6d958 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
+ Coverage   59.80%   60.45%   +0.65%     
==========================================
  Files         138      142       +4     
  Lines        9546     9880     +334     
==========================================
+ Hits         5709     5973     +264     
- Misses       3116     3160      +44     
- Partials      721      747      +26

Impacted Files	Coverage Δ
components/configstores/nacos/config.go	`60.60% <60.60%> (ø)`
components/configstores/nacos/configstore.go	`79.42% <79.42%> (ø)`
components/configstores/nacos/default_logger.go	`100.00% <100.00%> (ø)`
components/configstores/nacos/errors.go	`100.00% <100.00%> (ø)`
pkg/runtime/runtime.go	`54.59% <100.00%> (+0.11%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

components/configstores/nacos/configstore.go

components/configstores/nacos/const.go

components/configstores/nacos/config.go

components/configstores/nacos/configstore.go

components/configstores/nacos/default_logger_test.go

components/configstores/nacos/default_logger.go

components/configstores/nacos/configstore.go

components/configstores/nacos/change_listener.go

…ubscribe.

… path.

wenxuwan · 2023-06-21T06:11:31Z

@cyb0225 reviewer的cr的comments如果修复了，可以在comments下面回复个done之类的，然后reviewer可以继续cr，如果没问题了，reviewer才可以点

components/configstores/nacos/default_logger_test.go

components/configstores/nacos/const.go

wenxuwan · 2023-06-29T04:26:07Z

根据这个 https://mosn.io/layotto/#/zh/development/developing-component 文档，写个demo和快速开始文档再，🌹

update default Logfile name. change the log test case.

cyb0225 · 2023-06-29T17:20:19Z

根据这个 https://mosn.io/layotto/#/zh/development/developing-component 文档，写个demo和快速开始文档再，🌹

这个 ci 错误感觉可以忽略，因为我在代码里提前写了 nacos config 的路径，不过还没 merge 进去所以 deadlink 这个 ci 没跑通。

quick start 我打算 merge 进去后，写一个 docker-compose，用新版的 layotto 重新提一个 pr，你看看怎么样。

wenxuwan · 2023-06-30T03:12:12Z

quick start 我打算 merge 进去后，写一个 docker-compose，用新版的 layotto 重新提一个 pr，你看看怎么样。

嗯，是可以忽略

wenxuwan

LGTM， @cyb0225 感谢贡献

cyb0225 marked this pull request as draft June 7, 2023 16:53

layotto-cla bot added cla:yes size/XL size/XXL and removed size/XL labels Jun 7, 2023

wenxuwan self-requested a review June 9, 2023 07:37

cyb0225 changed the title ~~feat: support nacos configstore component (level1)~~ feat: support nacos configstore component (level2) Jun 10, 2023

cyb0225 added 15 commits June 14, 2023 16:49

feat: nacos configstore component support get and set operate.

0efc4ce

feat: register nacos to configstore factory.

d2f44c1

feat: add nacos config file.

b06b4c5

feat: nacos configstore component add default logger and support list…

8946661

…ening configs.

feat: nacos configstore component add test file for change_listener.

aa33500

feat: nacos configstore component delete config change listening when…

82ce0a3

… delete that config key.

chore: nacos component files add license and change the import order.

819574b

feat: nacos configstore component add mock.

213ee96

feat: nacos configstore component add config parse.

8de6925

feat: nacos configstore component improve error check mechanism.

d901215

feat: nacos configstore component use const variables instead of stri…

7544a56

…ng literals.

fix: nacos configstore component check config nil field to prevent pa…

6fd7e1b

…nic.

fix: fix nacos configstore component bugs when use get key level conf…

3b4fa12

…igs.

test: nacos configstore component add test files.

211d7ea

test: nacos configstore component improve testing strategy

df1fb1a

cyb0225 force-pushed the component-nacos branch 2 times, most recently from 1160a1f to 82ff44c Compare June 15, 2023 07:10

cyb0225 changed the title ~~feat: support nacos configstore component (level2)~~ feat: support nacos configstore component (level1) Jun 15, 2023

cyb0225 added 2 commits June 15, 2023 23:58

refactor: nacos configstore component.

29b795f

support level1 config functions. support connect to nacos use acm mode. fix error in filling in illegal characters when calling nacos set and delete parameters

feat: improve nacos configstore component test case.

1e36ff0

cyb0225 force-pushed the component-nacos branch from 82ff44c to 50b3f1c Compare June 16, 2023 04:20

feat: nacos configstore component support pagination.

2f3ce66

cyb0225 force-pushed the component-nacos branch from 50b3f1c to 2f3ce66 Compare June 16, 2023 04:26

cyb0225 marked this pull request as ready for review June 16, 2023 04:27

wenxuwan requested changes Jun 19, 2023

View reviewed changes

wenxuwan reviewed Jun 19, 2023

View reviewed changes

components/configstores/nacos/change_listener.go Outdated Show resolved Hide resolved

cyb0225 added 5 commits June 19, 2023 22:17

refactor: nacos configstore component uses sync map instead of map.

e71547d

refactor: nacos configstore component delete the global variable of s…

5572588

…ubscribe.

refactor: nacos configstore component support user set cache/log file…

5eac53a

… path.

refactor: configstore component add app_id field

51e4aee

refactor: use the log in mosn to replace nacos sdk log.

647c5eb

cyb0225 force-pushed the component-nacos branch from 0b17864 to 647c5eb Compare June 20, 2023 06:59

wenxuwan reviewed Jun 29, 2023

View reviewed changes

components/configstores/nacos/default_logger_test.go Outdated Show resolved Hide resolved

wenxuwan reviewed Jun 29, 2023

View reviewed changes

components/configstores/nacos/const.go Outdated Show resolved Hide resolved

cyb0225 added 2 commits June 29, 2023 19:29

Merge remote-tracking branch 'upstream/main' into component-nacos

286f354

refactor: update nacos configstore component.

313479d

update default Logfile name. change the log test case.

cyb0225 force-pushed the component-nacos branch from 4036edf to 313479d Compare June 29, 2023 11:36

docs: nacos configstore component add config usage docs.

aa6d958

cyb0225 force-pushed the component-nacos branch from 75ddc23 to aa6d958 Compare June 29, 2023 16:31

wenxuwan self-requested a review June 30, 2023 03:13

wenxuwan enabled auto-merge (squash) June 30, 2023 03:13

wenxuwan approved these changes Jun 30, 2023

View reviewed changes

wenxuwan merged commit 2354cd7 into mosn:main Jun 30, 2023
24 of 25 checks passed

wenxuwan approved these changes Jun 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support nacos configstore component (level1) #939

feat: support nacos configstore component (level1) #939

cyb0225 commented Jun 7, 2023 •

edited

Loading

github-actions bot commented Jun 7, 2023

cyb0225 commented Jun 16, 2023

codecov bot commented Jun 16, 2023 •

edited

Loading

wenxuwan commented Jun 21, 2023

wenxuwan commented Jun 29, 2023

cyb0225 commented Jun 29, 2023 •

edited

Loading

wenxuwan commented Jun 30, 2023

wenxuwan left a comment •

edited

Loading

feat: support nacos configstore component (level1) #939

feat: support nacos configstore component (level1) #939

Conversation

cyb0225 commented Jun 7, 2023 • edited Loading

情况完成

github-actions bot commented Jun 7, 2023

cyb0225 commented Jun 16, 2023

codecov bot commented Jun 16, 2023 • edited Loading

Codecov Report

wenxuwan commented Jun 21, 2023

wenxuwan commented Jun 29, 2023

cyb0225 commented Jun 29, 2023 • edited Loading

wenxuwan commented Jun 30, 2023

wenxuwan left a comment • edited Loading

Choose a reason for hiding this comment

cyb0225 commented Jun 7, 2023 •

edited

Loading

codecov bot commented Jun 16, 2023 •

edited

Loading

cyb0225 commented Jun 29, 2023 •

edited

Loading

wenxuwan left a comment •

edited

Loading