Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix grpc trace #978

Merged
merged 29 commits into from
Aug 2, 2023
Merged

feat: fix grpc trace #978

merged 29 commits into from
Aug 2, 2023

Conversation

wenxuwan
Copy link
Member

@wenxuwan wenxuwan commented Aug 2, 2023

What this PR does:

修复grpc的trace冲突

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


add contentlenth

fix version

remove unused changes

remove blank

remove blank
@layotto-cla layotto-cla bot added the bug Something isn't working label Aug 2, 2023
@wenxuwan wenxuwan changed the title feat: Fix grpc trace feat: fix grpc trace Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Hi @wenxuwan. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c484b6c) 60.20% compared to head (77a50e7) 60.20%.

❗ Current head 77a50e7 differs from pull request most recent head e333205. Consider uploading reports for the commit e333205 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #978   +/-   ##
=======================================
  Coverage   60.20%   60.20%           
=======================================
  Files         143      143           
  Lines       10005    10005           
=======================================
  Hits         6024     6024           
  Misses       3201     3201           
  Partials      780      780           
Files Changed Coverage Δ
components/trace/generator.go 85.71% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenxuwan wenxuwan merged commit 77d045b into mosn:main Aug 2, 2023
30 checks passed
@wenxuwan wenxuwan deleted the fix_grpc_trace branch August 2, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants