-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pod injection to deploy layotto as a sidecar in Kubernetes #993
Conversation
Hi @xiaoxiang10086, welcome to mosn community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
Hi @xiaoxiang10086. Thanks for your PR! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on it, but plz add a user-guide docs to thie feature along with this PR, thanks.
For specific user documentation, please refer to README.md. In this document I demonstrate how to use Helm to deploy the Layotto sidecar injector and deploy a Layotto application to interact with Layotto on kubernetes |
/area installation |
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some points:
- Use Docker Hub OCI to manage layotto injector helm charts and update related demos/docs.
- Add Sleep in demo to prevent shutting down container.
- Add layotto dockerfile under docker/layotto_injector
- Add build and push steps in layotto-ci workflows to build and push latest layotto-injector image.
- Add package and push steps in layotto-ci workflows to push latest layotto-injector helm chart in oci docker hub.
- Add release workflows for layotto-injector to release image and helm charts.
- Update demo/guide docs and migrate all demo,injector images/helm charts to
layotto
, will ask community to provide dockerhub pwd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❯ kgpo -w
NAME READY STATUS RESTARTS AGE
layotto-state-sdk-demo-6d8b87b7cd-qd6s7 0/2 ContainerCreating 0 4s
redis-master-0 1/1 Running 0 6m42s
redis-replicas-0 1/1 Running 0 6m42s
redis-replicas-1 1/1 Running 0 5m42s
redis-replicas-2 1/1 Running 0 5m17s
layotto-state-sdk-demo-6d8b87b7cd-qd6s7 1/2 Error 0 4s
layotto-state-sdk-demo-6d8b87b7cd-qd6s7 2/2 Running 1 (4s ago) 7s
Maybe we should set layotto as an init container.
/lgtm |
I think we need some e2e tests for this feature, but this could be a follow-up. |
[LGTMNOTIFIER] This PR is LGTM This pull-request has been lgtm by: @Xunzhuo The full list of commands accepted by this bot can be found here. The pull request process is described here. DetailsNeeds reviewers from an reviewer in each of these files: Reviewers can indicate their approval by writing |
/hold Will merge after CI passed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: @Xunzhuo The full list of commands accepted by this bot can be found here. The pull request process is described here. DetailsNeeds approval from an approver in each of these files: Approvers can indicate their approval by writing |
/hold cancel |
What this PR does:
支持 Layotto 以 sidecar 形态注入到 Kubernetes Pod 中
Which issue(s) this PR fixes:
Fixes #910
Special notes for your reviewer:
Does this PR introduce a user-facing change?: