-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nano precision option. #283
Conversation
Unsure whether to add test as existing tests dont test the format as it is.
Hey @ChrisDev83, Thanks for your contribution! What do you think about making the entire time format optional and including all supported formats? This will include exporting the time formats as constants to be passed as the format as string, instead of |
That would be a better approach, I found the formats odd as I come from "YYYY-mm-dd" world! But definitely more flexible that way. |
Actually, I remember why I went against the string format. I felt that given this is for k6 and the test config is written in Javascript, you need to know the format of go date/time format. So you would be supplying a go format in a javascript file. Unless you could allow a javascript date format and have a method to convert that to go format? |
@ChrisDev83 Let's keep this as is and open an issue to discuss that. Okay? |
Quality Gate passedIssues Measures |
This current open issue is related |
Released in v0.24.2. |
@ChrisDev83 Then, please update it with our discussion. |
Unsure whether to add test as existing tests dont test the format as it is. Feel free to tweak as needed!