Skip to content

MOSU refactor: Profile 입력값 한글로 변경 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wlgns12370 merged 1 commit into from
Aug 7, 2025
Merged

MOSU refactor: Profile 입력값 한글로 변경 #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/life/mosu/mosuserver/application/profile/ProfileService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package life.mosu.mosuserver.application.profile;

import life.mosu.mosuserver.domain.profile.entity.Gender;
import life.mosu.mosuserver.domain.profile.entity.ProfileJpaEntity;
import life.mosu.mosuserver.domain.profile.repository.ProfileJpaRepository;
import life.mosu.mosuserver.domain.user.entity.UserJpaEntity;
Expand Down Expand Up @@ -74,7 +75,7 @@ private void checkIfProfileExistsForUser(UserJpaEntity user) {

private void syncUserInfoFromProfile(UserJpaEntity user, SignUpProfileRequest request) {
if (user.isMosuUser()) {
user.updateUserInfo(request.validatedGender(), request.userName(),
user.updateUserInfo(Gender.fromName(request.gender()), request.userName(),
request.phoneNumber(), request.birth());
Comment on lines +78 to 79
Copy link

@gemini-code-assist gemini-code-assist bot Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To maintain consistency and proper error handling as suggested for SignUpProfileRequest, this should also use the proposed validatedGender() method. This ensures that invalid gender values are handled gracefully with a proper CustomRuntimeException before this method is called, and avoids duplicating the conversion logic.

Suggested change
user.updateUserInfo(Gender.fromName(request.gender()), request.userName(),
request.phoneNumber(), request.birth());
user.updateUserInfo(request.validatedGender(), request.userName(),
request.phoneNumber(), request.birth);

}
}
Expand Down
12 changes: 1 addition & 11 deletions src/main/java/life/mosu/mosuserver/presentation/profile/dto/SignUpProfileRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
import life.mosu.mosuserver.domain.profile.entity.Grade;
import life.mosu.mosuserver.domain.profile.entity.ProfileJpaEntity;
import life.mosu.mosuserver.global.annotation.PhoneNumberPattern;
import life.mosu.mosuserver.global.exception.CustomRuntimeException;
import life.mosu.mosuserver.global.exception.ErrorCode;

@Schema(description = "프로필 등록 요청 DTO")
public record SignUpProfileRequest(
Expand Down Expand Up @@ -48,20 +46,12 @@ public record SignUpProfileRequest(

) {

public Gender validatedGender() {
try {
return Gender.valueOf(gender.toUpperCase());
} catch (IllegalArgumentException | NullPointerException e) {
throw new CustomRuntimeException(ErrorCode.INVALID_GENDER);
}
}

public ProfileJpaEntity toEntity(Long userId) {
return ProfileJpaEntity.builder()
.userId(userId)
.userName(userName)
.birth(birth)
.gender(validatedGender())
.gender(Gender.fromName(gender))
.phoneNumber(phoneNumber)
.email(email)
.education(education)
Expand Down