Skip to content

fix: 빈 값 허용 + 오타 수정 #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbh010204 merged 3 commits into from
Aug 10, 2025
Merged

fix: 빈 값 허용 + 오타 수정 #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a58f8a
fix: update PhoneNumberPattern regex to allow empty phone number
jbh010204 Aug 10, 2025
7a89399
fix: remove typo in error code for invalid gender value
jbh010204 Aug 10, 2025
301188d
fix: remove typo in error code for invalid gender value
jbh010204 Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/life/mosu/mosuserver/domain/profile/entity/Gender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ public static Gender fromName(String genderName) {
.filter(g -> g.getGenderName().equals(genderName))
.findFirst()
.orElseThrow(
() -> new CustomRuntimeException(ErrorCode.INVAILD_GENDER));
() -> new CustomRuntimeException(ErrorCode.INVALID_GENDER));
}
}
2 changes: 1 addition & 1 deletion src/main/java/life/mosu/mosuserver/global/annotation/PhoneNumberPattern.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import java.lang.annotation.Target;

@Pattern(
regexp = "^01[016789]-\\d{3,4}-\\d{4}$",
regexp = "^(|01[016789]-\\d{3,4}-\\d{4})$",
message = "전화번호 형식은 010-XXXX-XXXX 이어야 합니다."
Comment on lines +12 to 13
Copy link

@gemini-code-assist gemini-code-assist bot Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the regular expression has been correctly updated to allow an empty string, the validation message on the following line is now inconsistent. It should be updated to reflect that an empty value is also permissible, which will prevent confusion for the user.

        regexp = "^(|01[016789]-\d{3,4}-\d{4})$",
        message = "전화번호는 010-XXXX-XXXX 형식이거나 비어있어도 됩니다."

)

Expand Down
1 change: 0 additions & 1 deletion src/main/java/life/mosu/mosuserver/global/exception/ErrorCode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public enum ErrorCode {
USER_INFO_INVALID(HttpStatus.BAD_REQUEST, "유효하지 않은 사용자 정보입니다."),
USER_NOT_ACCESS_FORBIDDEN(HttpStatus.BAD_REQUEST, "접근 권한이 없는 사용자입니다"),
USER_SAVE_FAILED(HttpStatus.INTERNAL_SERVER_ERROR, "사용자 저장에 실패했습니다."),
INVAILD_GENDER(HttpStatus.BAD_REQUEST, "유효하지 않은 성별 값입니다."),
// 신청 관련 에러
WRONG_SUBJECT_TYPE(HttpStatus.BAD_REQUEST, "잘못된 과목명 입니다."),
WRONG_LUNCH_TYPE(HttpStatus.BAD_REQUEST, "잘못된 도시락명 입니다."),
Expand Down