Skip to content

Comments

refactor: remove CUSTOMER_KEY_CHECK from whitelist#295

Merged
wlgns12370 merged 1 commit intoprodfrom
develop
Aug 10, 2025
Merged

refactor: remove CUSTOMER_KEY_CHECK from whitelist#295
wlgns12370 merged 1 commit intoprodfrom
develop

Conversation

@wlgns12370
Copy link
Contributor

No description provided.

@wlgns12370 wlgns12370 merged commit 187cab3 into prod Aug 10, 2025
2 checks passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @wlgns12370, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've refactored the application's whitelist configuration. This change simplifies the whitelist by removing an entry that is no longer needed or used, contributing to cleaner and more maintainable code.

Highlights

  • Whitelist Refactoring: Removed the CUSTOMER_KEY_CHECK entry from the Whitelist enum in src/main/java/life/mosu/mosuserver/global/filter/Whitelist.java. This entry was associated with the /api/v1/user/customer-key GET endpoint.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the /api/v1/user/customer-key endpoint from the authentication whitelist. This is a correct and necessary change, as the corresponding controller method requires authentication via @PreAuthorize. Previously, having this endpoint in the whitelist would cause the TokenFilter to skip authentication, leading to an authorization failure at the controller. This change resolves that inconsistency and ensures the endpoint functions correctly according to its security requirements. The change is clean and looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant