prod :전반적인 도메인 로직 내에서 validation 체크 및 NPE 안정성 보강#309
Conversation
…o refactor/mosu-241
…ner creation validation
…proving duplicate exam handling
…urationJpaVO method
…ements in ErrorCode
…st and EventResponse
전반적인 도메인 로직 내에서 validation 체크 및 NPE 안정성 보강
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @polyglot-k, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've focused on reinforcing the overall domain logic by enhancing validation checks and improving null-pointer safety. This involved adding new validation rules for user agreements and exam dates, refining existing checks for user sign-up and duplicate exam applications, and ensuring better null handling across various data transfer objects and entities. Additionally, I've updated dashboard metrics for more accurate reporting and performed general code cleanup to improve maintainability.
Highlights
- Enhanced Application Validation: I've significantly enhanced the application process by introducing new validation rules. Users must now explicitly agree to terms, and the system will prevent applications with empty or duplicate exam selections. This ensures data integrity and a smoother user experience.
- Improved Null-Safety: I've implemented comprehensive null-safety checks across various DTOs and entities, such as
ExamJpaEntity,EventRequest, andExamRequest. This reduces the likelihood ofNullPointerExceptions and makes the system more robust. - Refined Database Queries with 'Deleted' Filters: To ensure data accuracy and prevent issues with soft-deleted records, I've refined numerous repository queries. These queries now explicitly filter out entities marked as 'deleted', particularly for payment-related operations.
- Updated Dashboard Metrics: The admin dashboard now provides more accurate and relevant metrics. I've updated the counts to specifically reflect aborted refunds and the total number of non-admin users, offering a clearer operational overview.
- New Specific Error Codes: I've introduced several new error codes to provide more specific feedback for validation failures, including cases where terms are not agreed upon, no exams are applied, or exam dates conflict with deadlines.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request focuses on improving validation and null-safety across the application, which is a great initiative. The changes include adding validation for user agreements, exam dates, and request inputs, as well as moving validation logic to more appropriate locations. Many parts of the code have been fortified against NullPointerExceptions by adding null checks before accessing potentially null objects. I've identified a couple of areas where these improvements could be extended: one potential NullPointerException in the exam service and a case where a previously existing validation check was removed, which I recommend restoring. Overall, these are solid improvements to the robustness of the codebase.
| if (!request.deadlineTime().isBefore(request.examDate().atStartOfDay())) { | ||
| throw new CustomRuntimeException(ErrorCode.EXAM_DATE_AFTER_DEADLINE); | ||
| } |
There was a problem hiding this comment.
The deadlineTime in ExamRequest can be null, which will cause a NullPointerException when request.deadlineTime().isBefore() is called. You should add a null check for deadlineTime before using it.
| if (!request.deadlineTime().isBefore(request.examDate().atStartOfDay())) { | |
| throw new CustomRuntimeException(ErrorCode.EXAM_DATE_AFTER_DEADLINE); | |
| } | |
| if (request.deadlineTime() != null && !request.deadlineTime().isBefore(request.examDate().atStartOfDay())) { | |
| throw new CustomRuntimeException(ErrorCode.EXAM_DATE_AFTER_DEADLINE); | |
| } |
| List<ExamJpaEntity> existingExams = examJpaRepository.findAllById(examIdSet); | ||
|
|
||
| lunchSelection(requests, existingExams); |
There was a problem hiding this comment.
The validation to check if all requested exams exist has been removed. findAllById will silently ignore non-existent IDs, which could lead to unexpected behavior. It's important to verify that all provided examIds correspond to actual exams in the database by comparing the size of the examIdSet with the number of existingExams found.
| List<ExamJpaEntity> existingExams = examJpaRepository.findAllById(examIdSet); | |
| lunchSelection(requests, existingExams); | |
| List<ExamJpaEntity> existingExams = examJpaRepository.findAllById(examIdSet); | |
| if (existingExams.size() != examIdSet.size()) { | |
| throw new CustomRuntimeException(ErrorCode.EXAM_NOT_FOUND); | |
| } | |
| lunchSelection(requests, existingExams); |
2 participants
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타