feat: implement saveOrGetUser method to streamline user creation and …#311
feat: implement saveOrGetUser method to streamline user creation and …#311polyglot-k merged 1 commit intoprodfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @polyglot-k, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've introduced a new saveOrGetUser method to streamline the process of handling user creation and retrieval. This change ensures that when a user applies as a guest, the system first checks if a user with the provided phone number already exists. If so, it retrieves the existing user's ID; otherwise, it proceeds to save a new user. This prevents duplicate user entries and optimizes user management during guest applications.
Highlights
- User Management Enhancement: I've implemented a new method,
saveOrGetUser, in theUserServiceto intelligently handle user creation. This method first checks if a user with the provided phone number already exists in the database. If a user is found, their existing ID is returned, preventing duplicate entries. If no existing user is found, a new user entity is saved, and its ID is returned. - Application Flow Optimization: The
ApplicationServicehas been updated to leverage the newly introducedsaveOrGetUsermethod. Specifically, theapplyByGuestmethod now callsuserService.saveOrGetUserinstead of the previoususerService.saveUser. This ensures that when guest applications are processed, the system efficiently reuses existing user profiles based on phone number or creates new ones only when necessary, streamlining the application flow.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a saveOrGetUser method to streamline user creation by either finding an existing user by phone number or creating a new one. This is a good improvement for handling guest user applications. My review focuses on a potential race condition in the new method that could lead to errors under concurrent load. I've provided a suggestion to make the implementation more robust and handle this concurrency issue gracefully.
| public Long saveOrGetUser(UserJpaEntity user) { | ||
| return userJpaRepository.findByPhoneNumber(user.getPhoneNumber()) | ||
| .map(UserJpaEntity::getId) | ||
| .orElseGet(() -> { | ||
| Long userId = userJpaRepository.save(user).getId(); | ||
| if (userId == null) { | ||
| throw new CustomRuntimeException(ErrorCode.USER_SAVE_FAILED); | ||
| } | ||
| return userId; | ||
| }); | ||
| } |
There was a problem hiding this comment.
The current implementation of saveOrGetUser is vulnerable to a race condition. If two concurrent requests attempt to create a user with the same phone number, both might find that the user doesn't exist and then both attempt to save a new user. This will lead to one of the transactions failing with a unique constraint violation (e.g., DataIntegrityViolationException).
To handle this, you can catch the DataIntegrityViolationException and re-query for the user, which should exist at that point. This is a common pattern for handling get-or-create scenarios under concurrency.
Additionally, I recommend annotating the method with @Transactional to ensure it always runs within a transaction, providing predictable behavior. You'll need to import org.springframework.transaction.annotation.Transactional and org.springframework.dao.DataIntegrityViolationException.
| public Long saveOrGetUser(UserJpaEntity user) { | |
| return userJpaRepository.findByPhoneNumber(user.getPhoneNumber()) | |
| .map(UserJpaEntity::getId) | |
| .orElseGet(() -> { | |
| Long userId = userJpaRepository.save(user).getId(); | |
| if (userId == null) { | |
| throw new CustomRuntimeException(ErrorCode.USER_SAVE_FAILED); | |
| } | |
| return userId; | |
| }); | |
| } | |
| @Transactional | |
| public Long saveOrGetUser(UserJpaEntity user) { | |
| return userJpaRepository.findByPhoneNumber(user.getPhoneNumber()) | |
| .map(UserJpaEntity::getId) | |
| .orElseGet(() -> { | |
| try { | |
| Long userId = userJpaRepository.save(user).getId(); | |
| if (userId == null) { | |
| throw new CustomRuntimeException(ErrorCode.USER_SAVE_FAILED); | |
| } | |
| return userId; | |
| } catch (org.springframework.dao.DataIntegrityViolationException e) { | |
| // Race condition: another transaction might have created the user. Re-fetch. | |
| return userJpaRepository.findByPhoneNumber(user.getPhoneNumber()) | |
| .map(UserJpaEntity::getId) | |
| .orElseThrow(() -> new CustomRuntimeException(ErrorCode.USER_SAVE_FAILED)); | |
| } | |
| }); | |
| } |
1 participant
…retrieval
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타