Prod : 게스트, 일반 사용자 PhoneNUmber 구분할 수 있도록 구성#313
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @polyglot-k, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've implemented changes to differentiate between guest and general user phone numbers within the system. This involves prefixing phone numbers with 'G' for guests and 'U' for regular users to clearly distinguish their accounts in the database and ensure proper handling across various services.
Highlights
- Phone Number Formatting: I've introduced new utility methods in
PhoneNumberUtilto prefix phone numbers with 'G' for guest users and 'U' for general users, ensuring distinct identification within the system. - User Data Handling: I've updated user creation and update flows in
ApplicationGuestRequest,SignUpAccountRequest, andOAuthUserPersistenceProcessorto apply these new phone number formatting rules consistently. - User Lookup Consistency: I've modified
MyUserServiceto correctly retrieve user information by applying the standard phone number format during lookups, ensuring compatibility with the newly prefixed numbers. - External System Compatibility: I've adjusted
NotifyServiceand added agetPhoneNumber()method inUserJpaEntityto strip the prefix when retrieving phone numbers for external use, ensuring compatibility with existing notification systems and external integrations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to distinguish between guest and regular user phone numbers by adding a 'G' or 'U' prefix. The changes are applied across user creation and update flows. My review focuses on improving the implementation's robustness and maintainability. I've identified a critical issue in UserJpaEntity where a getter is overridden in a way that could lead to a NullPointerException and other subtle bugs. I've also suggested centralizing the logic for removing the phone number prefix into PhoneNumberUtil to avoid code duplication and improve clarity.
| public String getPhoneNumber() { | ||
| return phoneNumber.replaceFirst("^.", ""); | ||
| } |
There was a problem hiding this comment.
Overriding a getter for a JPA entity field to return a modified value is an anti-pattern. It can cause unexpected behavior with persistence frameworks and breaks the principle of least astonishment. A getter should return the raw field value. It's recommended to rename this method to something like getRawPhoneNumber() and restore the default getter for phoneNumber (e.g., by letting Lombok generate it).
Additionally, the current implementation phoneNumber.replaceFirst("^.", "") will throw a NullPointerException if phoneNumber is null, as the field is nullable.
Here is a safer implementation with a more appropriate method name:
public String getRawPhoneNumber() {
if (phoneNumber == null || phoneNumber.isEmpty()) {
return phoneNumber;
}
return phoneNumber.substring(1);
}| public static String formatPhoneNumber(String phoneNumber) { | ||
| return String.format("U%s", phoneNumber); | ||
| } |
There was a problem hiding this comment.
To avoid duplicating the logic for removing the phone number prefix (as seen in NotifyService and UserJpaEntity), and to improve readability over replaceFirst("^.", ""), consider adding a utility method here to handle that.
This centralizes the logic and makes the code easier to maintain. You can then use PhoneNumberUtil.stripPrefix() in other parts of the code.
public static String formatPhoneNumber(String phoneNumber) {
return String.format("U%s", phoneNumber);
}
public static String stripPrefix(String phoneNumber) {
if (phoneNumber == null || phoneNumber.isEmpty()) {
return phoneNumber;
}
return phoneNumber.substring(1);
}1 participant
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타