feat: integrate phone number formatting in saveOrGetUser method#314
feat: integrate phone number formatting in saveOrGetUser method#314polyglot-k merged 1 commit intoprodfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @polyglot-k, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've implemented a feature to integrate phone number formatting directly into the saveOrGetUser method within the UserService. This change ensures that all phone numbers are consistently formatted before they are used to either retrieve an existing user or save a new one. The primary goal is to prevent duplicate user entries that might arise from inconsistent phone number formats and to streamline the user lookup process.
Highlights
- Phone Number Formatting Integration: Integrated PhoneNumberUtil.formatGuestPhoneNumber into the saveOrGetUser method within UserService.java. This ensures that phone numbers are consistently formatted before being used to query the database, improving data consistency and lookup reliability.
- Dependency Addition: Added an import for life.mosu.mosuserver.global.util.PhoneNumberUtil in UserService.java to support the new phone number formatting logic.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request integrates phone number formatting into the saveOrGetUser method, specifically to look up guest users. While the intent is clear, the implementation has a critical flaw. The current logic can lead to unhandled DataIntegrityViolationException if a non-guest user with the same phone number already exists, because the lookup only checks for guest users before attempting to save a new user. This can prevent new users from being created correctly and cause application errors. The root of this issue is compounded by a design problem in UserJpaEntity.getPhoneNumber().
| return userJpaRepository.findByPhoneNumber( | ||
| PhoneNumberUtil.formatGuestPhoneNumber(user.getPhoneNumber())) |
There was a problem hiding this comment.
The current logic for saveOrGetUser is prone to causing DataIntegrityViolationException and subsequent application errors.
The method first attempts to find an existing user by a guest-formatted phone number (G prefix). If no guest user is found, it proceeds to save the new user object in the orElseGet block.
The issue arises if a non-guest user (e.g., with a U prefix) already exists with the same phone number. The initial lookup for the guest user will fail, and the code will attempt to save the new user, leading to a unique constraint violation on the phone_number column.
For example:
- A user with phone number
U01012345678exists in the database. saveOrGetUseris called with a newUserJpaEntitywhose phone number is alsoU01012345678.- The code will look up
G01012345678and won't find it. - It will then try to save the new user with
U01012345678, which will fail.
This logic is further complicated by the UserJpaEntity.getPhoneNumber() method, which strips the prefix from the phone number, making it difficult to perform a lookup for the user's actual stored phone number.
To fix this, the logic should be revised to check for any existing user with the same base phone number before attempting to save. A proper fix would likely require changes to UserJpaEntity to allow accessing the raw phone number without modification.
1 participant
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타