-
Notifications
You must be signed in to change notification settings - Fork 2
prod: 신청 시 추천인 검증 개선 #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
prod: 신청 시 추천인 검증 개선 #318
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,7 +143,6 @@ Optional<ExamApplicationNotifyProjection> findExamAndPaymentByExamApplicationId( | |
| JOIN PaymentJpaEntity p ON p.examApplicationId = ea.id | ||
| WHERE ea.id = :examApplicationId | ||
| AND p.paymentStatus = 'DONE' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| AND p.deleted = false | ||
| """) | ||
| Optional<ExamInfoWithExamNumberProjection> findExamInfoWithExamNumber( | ||
| @Param("examApplicationId") Long examApplicationId); | ||
|
|
@@ -194,4 +193,17 @@ SELECT COUNT(ea) | |
| AND p.deleted = false | ||
| """) | ||
| long countAll(); | ||
|
|
||
| @Query(""" | ||
| select exists ( | ||
| select 1 | ||
| from ExamApplicationJpaEntity ea | ||
| join PaymentJpaEntity p on p.examApplicationId = ea.id | ||
| where ea.userId = :userId | ||
| and p.paymentStatus = 'DONE' | ||
| and p.deleted = false | ||
| and ea.deleted = false | ||
| ) | ||
| """) | ||
| boolean existsPaymentDoneByUserId(@Param("userId") Long userId); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verifyRecommender메서드의 로직을 더 간결하게 개선할 수 있습니다.if문을 사용하는 대신, 논리 AND(&&) 연산자를 사용하여 한 줄로 표현하면 가독성이 향상됩니다.