Skip to content

feat: add empty notification button URL to ApplicationGuestNotifyRequest #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polyglot-k merged 1 commit into from
Aug 12, 2025
Merged

feat: add empty notification button URL to ApplicationGuestNotifyRequest #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/life/mosu/mosuserver/application/notify/dto/ApplicationGuestNotifyRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public static ApplicationGuestNotifyRequest from(
@Override
public LunaNotificationButtonUrls getNotificationButtonUrls() {
return LunaNotificationButtonUrls.of(
NotificationButtonUrl.empty(),
Copy link

@gemini-code-assist gemini-code-assist bot Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The purpose of adding an empty notification button via NotificationButtonUrl.empty() is not immediately obvious from the code. This can make the code harder to understand and maintain for future developers, as it suggests a hidden requirement from the downstream notification service. To improve clarity, please consider adding a comment explaining why this empty button is necessary.

For example:

// The notification template requires two buttons; the first is a placeholder.
NotificationButtonUrl.empty(),

NotificationButtonUrl.of(WARNING_PAGE, WARNING_PAGE)
);
}
Expand Down