Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update/delete should not fail when table has multi-column primary key #32

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

elefeint
Copy link
Contributor

Joining multiple column clauses in WHERE columns should be done with an " AND ", not with ", ".

Fixes #31

@elefeint elefeint requested a review from awitten1 March 18, 2024 22:57
Copy link

@awitten1 awitten1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elefeint elefeint merged commit 5e40db6 into main Mar 19, 2024
1 check passed
@elefeint elefeint deleted the delete_multiple_keys branch March 19, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

soft delete should support multiple keys properly
2 participants