Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the file is accessible before trying to read it #35

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Check the file is accessible before trying to read it #35

merged 6 commits into from
Mar 26, 2024

Conversation

elefeint
Copy link
Contributor

@elefeint elefeint commented Mar 26, 2024 •
edited
Loading

I really should have fixed it the first time I lost time troubleshooting decryption.
Also makes IS_FAIL both more and less flexible -- it now supports substring matching rather than full string, but it also fails if the criterion is not matched.

Fixes #8

@elefeint elefeint requested a review from guenp March 26, 2024 20:50
guenp
guenp approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@guenp guenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

test/integration/test_server.cpp Outdated Show resolved Hide resolved
test/integration/test_server.cpp Outdated Show resolved Hide resolved
src/motherduck_destination_server.cpp Outdated Show resolved Hide resolved
@elefeint elefeint merged commit 1113e7c into main Mar 26, 2024
1 check passed
@elefeint elefeint deleted the fix_file_inaccessible branch March 26, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guenp guenp guenp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for file access before trying to read it
2 participants
@elefeint @guenp