More accurate bind errors #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guenp
reviewed
Sep 19, 2024
| mdlog::info("truncate_table: " + query); | ||
| auto statement = con.Prepare(query); | ||
| if (statement->HasError()) { | ||
| throw std::runtime_error(err + " (at bind step):" + statement->GetError()); |
There was a problem hiding this comment.
Here we say at bind step twice, effectively:
"Error truncating table at bind step <" + absolute_table_name + ">" + " (at bind step):"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if the query is invalid, the error message is unhelpful -- "Attempting to execute an unsuccessfully prepared statement!". This PR surfaces bind errors instead of trying to run the invalid query.
I also threw in a couple of extra log lines in Truncate endpoint because that's the best guess so far about what's segfaulting for some but not all connectors in prod.