Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workaround to drop the bad table instead of truncating #52

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

elefeint
Copy link
Contributor

@elefeint elefeint commented Sep 4, 2024

Some tables got created with no columns except _fivetran_deleted. This PR drops the bad tables instead of truncating them because the truncation will fail anyway (since the _fivetran_synced column is not present.

We'll revert the workaround once all shared customer connectors get fixed.
Fixes #51 .

@elefeint elefeint requested a review from hrl20 September 4, 2024 21:29
Copy link
Contributor

@hrl20 hrl20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@elefeint elefeint merged commit c133710 into main Sep 5, 2024
1 check passed
@elefeint elefeint deleted the workaround_bad_tables branch September 5, 2024 23:17
elefeint added a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work around bad tables with only one column, _fivetran_deleted
2 participants