Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python_safety: Use setup-python to create a venv #2847

Merged
merged 5 commits into from
Oct 4, 2023
Merged

python_safety: Use setup-python to create a venv #2847

merged 5 commits into from
Oct 4, 2023

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Oct 4, 2023 •
edited
Loading

As recommended at #2837 (comment)

@MichaIng
Copy link
Member

MichaIng commented Oct 4, 2023 •
edited
Loading

But there is still no motionEye installed or any of its (Python) dependencies. If it also check Python code, or requirements.txt, then at least the repo would need to be cloned.

EDIT: Ah, oversight, the repo is cloned.

@MichaIng
Copy link
Member

MichaIng commented Oct 4, 2023 •
edited
Loading

The other failing test(s) are fixed here: #2848

Ah probably a conflict since you removed the system upgrade here. Probably you are right and there is no point for the apt upgrade here? Even the other APT package installs shouldn't have no effect on safety, do they?

@cclauss
Copy link
Member Author

cclauss commented Oct 4, 2023

Some apt packages such as curl are required for pip install . to work.

@MichaIng MichaIng force-pushed the python_safety-Use-setup-python-to-create-a-venv branch from 468cdf5 to 8e21c9e Compare October 4, 2023 21:26
@MichaIng
Update python_safety.yml
737267a 
- Run on Ubuntu Jammy
- Remove obsolete GRUB package hold
- Install only packages required for motionEye build
@MichaIng MichaIng added the CI/CD label Oct 4, 2023
MichaIng
MichaIng approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@MichaIng MichaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only libcurl headers are required 😉. I removed the GRUB upgrade workaround from the other PR, now obsolete as no dist-upgrade is done. And it makes sense to run on latest Ubuntu Jammy instead of Focal.

@MichaIng MichaIng merged commit 192d210 into dev Oct 4, 2023
17 checks passed
@MichaIng MichaIng deleted the python_safety-Use-setup-python-to-create-a-venv branch October 4, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaIng MichaIng MichaIng approved these changes

Assignees

@cclauss cclauss

Labels
CI/CD
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @MichaIng