Skip to content

Make snapshot/streaming/embed (URLs) pop-ups work on all translations #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Make snapshot/streaming/embed (URLs) pop-ups work on all translations #3020

merged 1 commit into from
Jun 30, 2024

Conversation

Marijn0
Copy link
Contributor

@Marijn0 Marijn0 commented Jun 28, 2024

Fixes #2891

Changed the function runAlertDialog to not depend on the selected language.

@MichaIng
I hope this is how you envisioned the solution. If I need to change anything, please let me know!

@Marijn0 Marijn0 changed the title Make snapshot/streaming/embed pop-ups work on all translations Make snapshot/streaming/embed (URLs) pop-ups work on all translations Jun 28, 2024
@MichaIng MichaIng linked an issue Jun 30, 2024 that may be closed by this pull request
@MichaIng MichaIng added this to the v0.43.1 milestone Jun 30, 2024
@MichaIng MichaIng added the bug label Jun 30, 2024
Copy link
Member

@MichaIng MichaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this is the button ID processed by runModalDialog() and was never meant to be translated. Instead, there are title and label options passed and/or set by the function, which are and can be translated.

@MichaIng MichaIng merged commit 9f17117 into motioneye-project:dev Jun 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Motioneye 0.43 No streaming popup on german
2 participants