Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Message-ID to emails. #3028

Closed
wants to merge 1 commit into from
Closed

Conversation

donlorenzo
Copy link

RFC-2822 specifies that every email SHOULD have a Message-ID field. Some mail servers reject emails that do not have a Message-ID.
The eMails sent out by motioneye do not have a Message-ID.
This PR adds a Message-ID to the emails sent out by motioneye.

Copy link
Collaborator

@zagrim zagrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. And a good addition, since being able to get email through seems to rely on a ton of things these days.

Copy link
Collaborator

@zagrim zagrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually one thing that should change is the base branch of this PR, I think. The base should be dev branch of motioneye-project.

@zagrim
Copy link
Collaborator

zagrim commented Jul 21, 2024

I could also change the base branch of this PR but maybe it's better if you @donlorenzo check first that your change doesn't break if you rebase it on the current dev branch 😅 (there seem to be no changes to sendmail.py though between the branches)

@donlorenzo
Copy link
Author

I withdraw this PR in favor of #3030 targeting the dev branch.

@donlorenzo donlorenzo closed this Jul 21, 2024
@MichaIng
Copy link
Member

The base branch can be changed with the edit button at the top of the PR, and the a rebase onto the base branch can be done at the bottom of the page. No need to reopen a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants