Fixes #6 #35
Open
Fixes #6 #35
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonicbluesky
added a commit
to sonicbluesky/suncalc
that referenced
this pull request
Jan 21, 2025
use the fix xqjibz recommended. upstream (mourner) never merged xqjibz's pull request because it would've broken dependent apps. it was suggested to merge the pr with a major version increment in order to avoid dependent apps automatically updating, but that suggestion was never heeded. my repo doesn't have dependent apps right now so i can go ahead and just solve this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #6, this is before the fix:
and after, all in degrees, because I'm unable to read radians :)
tests updated too