Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEMP: Remove ROS' octomap after 'rosdep install' #2855

Closed
wants to merge 2 commits into from

Conversation

rhaschke
Copy link
Contributor

Quick, temporary solution for #2851 (comment).

@rhaschke rhaschke requested a review from henningkayser May 26, 2024 19:37
@henningkayser
Copy link
Member

henningkayser commented May 31, 2024

I pulled this into #2851 for now to complete the CI fixes, even though this should really only be a short-term solution.
If possible, we should not prevent users to have the ROS package installed. I'm thinking about solving this by setting a version filter in the find_package call. Unfortunately, we can not declare the liboctomap-dev dependency in the package.xml, but at least we know that it must be available since it must be provided along with fcl.

I'm continuing to track this in #2846

@rhaschke
Copy link
Contributor Author

At least we know that it (octomap) must be available since it must be provided along with fcl.

That's true for moveit_core, but not for geometric_shapes!

I explicitly filed a new PR for this change to not mangle it as part of #2851. This will allow to revert the change more easily in the future.

@rhaschke rhaschke deleted the drop-rolling-octomap branch June 8, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants