Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts default launch argument "capabilities" to not cause an error #2912

Conversation

b-adkins
Copy link

@b-adkins b-adkins commented Jul 15, 2024

Reverts capabilities default value to the empty string. Reverts #2696.

The issue is extensively documented:

Description

Reverted the backport to the empty string, which it was before the merge that apparently broke things. Alternatively,

default_value=moveit_config.move_group_capabilities

was suggested in these discussions. Both worked on my system.

…96, which broke MoveIt launch files output by the setup assistant.
@b-adkins b-adkins mentioned this pull request Aug 8, 2024
Copy link

github-actions bot commented Oct 3, 2024

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Oct 3, 2024
Copy link

mergify bot commented Oct 3, 2024

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@mikeferguson
Copy link
Contributor

I would suggest we take #3018 instead of this at it fixes the issue but also keeps the "new" feature that was intended (and then back port it to humble/iron as well)

@github-actions github-actions bot removed the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Oct 4, 2024
@sjahr
Copy link
Contributor

sjahr commented Oct 11, 2024

Closing this in favor of #3018. @b-adkins Thanks for providing this PR nonetheless!

@sjahr sjahr closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants