-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Never return nullptr silently #2969
Open
sjahr
wants to merge
14
commits into
moveit:main
Choose a base branch
from
sjahr:pr-never-silently-return-nullptr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+28
−2
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad4abfb - Browse repository at this point
Copy the full SHA ad4abfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d5332a - Browse repository at this point
Copy the full SHA 5d5332aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2a3f52 - Browse repository at this point
Copy the full SHA c2a3f52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a6b3e9 - Browse repository at this point
Copy the full SHA 7a6b3e9View commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bbdb5b1 - Browse repository at this point
Copy the full SHA bbdb5b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57a85c8 - Browse repository at this point
Copy the full SHA 57a85c8View commit details
Commits on Aug 26, 2024
-
Revert "Deprecate ugly function signature"
This reverts commit 57a85c8.
Configuration menu - View commit details
-
Copy full SHA for 598cc0c - Browse repository at this point
Copy the full SHA 598cc0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28a4975 - Browse repository at this point
Copy the full SHA 28a4975View commit details -
Apply suggestions from code review
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 4b173e7 - Browse repository at this point
Copy the full SHA 4b173e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9ffff2 - Browse repository at this point
Copy the full SHA f9ffff2View commit details -
Apply suggestions from code review
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ede820c - Browse repository at this point
Copy the full SHA ede820cView commit details -
Apply suggestions from code review
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 32d2fc0 - Browse repository at this point
Copy the full SHA 32d2fc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b21e45 - Browse repository at this point
Copy the full SHA 5b21e45View commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b36b888 - Browse repository at this point
Copy the full SHA b36b888View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.