-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove moveit2_humble.repos and moveit2_iron.repos files #3080
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hmm... is the new version of generate_parameter_library actually breaking things on Humble? https://github.com/moveit/moveit2/actions/runs/11779440054/job/32807896145?pr=3080#step:11:365 Weirdly enough I don't see in the logs Is this something where we need to first merge a PR to |
I think the issue is that the https://github.com/moveit/moveit2/actions/runs/11781805227/job/32815416596#step:5:346 EDIT: Oh! Of course, the |
@sea-bass Which version of generate_parameter_library is being installed by the CI / humble-ci job? I don't see it in the logs. |
My going theory is that the docker image this is running on is stale because other jobs are failing. I am trying to see if landing #3082 first and then letting the humble moveit image build will fix things. |
Confirming this:
If I simply run an Also, these logs from #3082 install the newer version: https://github.com/moveit/moveit2/actions/runs/11782484963/job/32817611887?pr=3082#step:5:922 So I'm hopeful this will pass once #3082 is in |
This is not passing. Somehow the Humble CI job still is not installing the latest generate_parameter_library. Is it that the ROS 2 Humble image is simply too old, and somehow the new package versions are not upgraded? EDIT: Yep, #3104 should address this |
Humble Docker images are finally being pushed again! This is ready. |
Description
The only dependency that was in these files was an old version of
generate_parameter_library
which we do not need to be on at the moment.I still kept the logic in the Dockerfiles in case there ever needs to be distro-specific repos files in future.
Checklist