Update deprecated tf2 imports from .h to .hpp #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
added
backport-humble
6 tasks
|
Tutorial images CI fixed in #3196 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3197 +/- ##
==========================================
+ Coverage 0.00% 45.99% +45.99%
==========================================
Files 75 714 +639
Lines 8829 62302 +53473
Branches 1456 7528 +6072
==========================================
+ Hits 0 28652 +28652
- Misses 8829 33483 +24654
- Partials 0 167 +167 ☔ View full report in Codecov by Sentry. |
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
* Update deprecated tf2 imports from .h to .hpp * make the imports conditional * Update all the files (cherry picked from commit 7390ebc)
mergify bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
* Update deprecated tf2 imports from .h to .hpp * make the imports conditional * Update all the files (cherry picked from commit 7390ebc) # Conflicts: # moveit_core/robot_state/test/test_aabb.cpp # moveit_kinematics/cached_ik_kinematics_plugin/include/moveit/cached_ik_kinematics_plugin/cached_ik_kinematics_plugin.hpp # moveit_planners/chomp/chomp_motion_planner/src/chomp_planner.cpp # moveit_planners/pilz_industrial_motion_planner/include/pilz_industrial_motion_planner/trajectory_functions.hpp # moveit_planners/pilz_industrial_motion_planner/src/trajectory_functions.cpp # moveit_planners/pilz_industrial_motion_planner/src/trajectory_generator_circ.cpp # moveit_ros/robot_interaction/src/interactive_marker_helpers.cpp # moveit_ros/robot_interaction/src/robot_interaction.cpp
This was referenced Jan 6, 2025
sea-bass
added a commit
that referenced
this pull request
Jan 6, 2025
sea-bass
added a commit
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Surprise! More deprecations.
ros2/geometry2#720
This was also backported to Jazzy and Humble, so we will do the same here.
NOTE: Because these changes have not yet made it into Humble binaries, I have conditional includes in. But once Humble gets a sync, we can undo a lot of this and just go full
.hpp.Checklist