Implement execution of swine-z3 on SMT2 files #65
Conversation
| fn execute_swine(dir: &Path, file_path: &Path) { | ||
| let swine = "swine-z3"; | ||
|
|
||
| let find_output = Command::new("find") |
There was a problem hiding this comment.
I don't understand why you'd be using find here? It should be sufficient to just do the call to swine directly.
| .output().unwrap(); | ||
|
|
||
| if cmd_output.status.success() { | ||
| println!("{}", String::from_utf8_lossy(&cmd_output.stdout)); |
There was a problem hiding this comment.
The next step would be to parse the output of SWINE and return a SatResult.
| println!("{}", String::from_utf8_lossy(&cmd_output.stdout)); | ||
| break; | ||
| } else { | ||
| eprintln!("Failed to execute swine({}) command with status: {}", line, cmd_output.status); |
There was a problem hiding this comment.
Ideally, return a Result and return an error in this case.
| } | ||
| } | ||
| } else { | ||
| eprintln!("Find command execution failed"); |
| } | ||
| } | ||
|
|
||
| fn remove_lines_for_swine(input: &str) -> String { |
There was a problem hiding this comment.
Please add a doc comment saying which lines this removes.
| @@ -94,6 +160,21 @@ impl<'ctx> Prover<'ctx> { | |||
| if self.min_level_with_provables.is_none() { | |||
| return ProveResult::Proof; | |||
| } | |||
|
|
|||
| let mut smtlib = self.get_smtlib(); | |||
There was a problem hiding this comment.
As a next step, add an solver_type attribute of a new enum type SolverType with variants Z3 and SWINE, and then choose here whether to invoke either Z3 or SWINE.
There was a problem hiding this comment.
You can do this like we did it for SliceVerifyMethod and the SliceOptions::slice_verify_via option in main.rs.
No description provided.