Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [libs/movex] fix Linting Issues Across the Movex Library #233 #238

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Fix [libs/movex] fix Linting Issues Across the Movex Library #233 #238

merged 2 commits into from
Jan 31, 2025

Conversation

ManikantaMandala
Copy link
Contributor

fixes #233

  • Added build configuration for movex-specs-util library because of the lint error

    "Buildable libraries cannot import or export from non-buildable libraries"

  • removed the object literals {} and added MovexClientInfo in the property type of ConnectionToMasterResources.ts

Result:
image

@ManikantaMandala
Copy link
Contributor Author

ManikantaMandala commented Oct 15, 2024 •
edited
Loading

Hey @GabrielCTroia review this please

@GabrielCTroia GabrielCTroia merged commit fec3b64 into movesthatmatter:main Jan 31, 2025
2 checks passed
@GabrielCTroia
Copy link
Contributor

Thank you @ManikantaMandala and sorry for the late merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libs/movex] Fix Linting Issues Across the Movex Library
2 participants
@ManikantaMandala @GabrielCTroia