Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a retry mechanism when the model download fails. #289

Conversation

Guocork
Copy link
Collaborator

@Guocork Guocork commented Oct 30, 2024

No description provided.

@Guocork
Copy link
Collaborator Author

Guocork commented Dec 13, 2024

@joulei Hello, I was wondering if anyone is currently working on fixing the timer issue on Linux in Makepad. If not, I can help investigate and fix it so that this PR can be merged.

@joulei
Copy link
Collaborator

joulei commented Dec 13, 2024

Hi @Guocork I had this on my to-do list but I haven't managed to prioritize it.
I'm going to be out next week so perhaps you can start looking into it. This is mostly about making the linux implementation of the timers match what the other platforms (windows, macOS, etc) are doing in terms of timers.

@Guocork
Copy link
Collaborator Author

Guocork commented Dec 13, 2024

Hi @Guocork I had this on my to-do list but I haven't managed to prioritize it. I'm going to be out next week so perhaps you can start looking into it. This is mostly about making the linux implementation of the timers match what the other platforms (windows, macOS, etc) are doing in terms of timers.

ok, I'll try to fix that

@Guocork
Copy link
Collaborator Author

Guocork commented Dec 21, 2024

Hi, @joulei I've fixed the Timer issue on Linux, and the details are Timer.
This PR is now open for review.This will take effect once the Timer PR is merged.

@Guocork Guocork marked this pull request as ready for review December 21, 2024 03:56
@joulei
Copy link
Collaborator

joulei commented Jan 6, 2025

@Guocork since now the linux timer fix has been merged into Makepad, would you mind updating this PR (resolving conflicts) so that we can merge it? thanks!

@Guocork
Copy link
Collaborator Author

Guocork commented Jan 12, 2025

Hello, @joulei I resolved the code conflicts and optimized some parts, but for some reason, there's an issue with the CI/CD. On my computer, the Timer still doesn't work properly. After investigating, I found that the Cargo.lock file is too outdated. I think we should run cargo update to update the Cargo.lock file to match the latest Makepad branch.

@joulei
Copy link
Collaborator

joulei commented Jan 13, 2025

@Guocork correct! would you mind running cargo update makepad-widgets and pushing the updated Cargo.lock to this branch? I don't have permissions to do so.

The CI issue with Windows is unrelated, you can safely ignore it for now.

@joulei joulei merged commit a0997b4 into moxin-org:dev Jan 22, 2025
5 checks passed
@Guocork Guocork deleted the Automatically-retry-the-download-when-it’s-interrupted branch January 23, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants