Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with localization plugins and implementaion solved #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahmadkhedr
Copy link

Solve the issue with formatting the card number and expiry date in case of Arabic Localization in a project

Copy link
Collaborator

@Fghurayri Fghurayri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ahmadkhedr

I appreciate submitting this PR to resolve your text direction issue when using a localization plugin. I tested this change locally without any localization plugin and works as expected. Hopefully you verified it from your side when using a localization plugin.

I left you some comments related to reverting the changes in files that aren't required to resolve the issue. Once you do the changes, I'll merge this PR and queue this fix for the upcoming release.

Thank you.

CreditCard(
locale: Localization.ar(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes of this file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes of this file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes of this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants