Skip to content

Commit

Permalink
Merge pull request #117 from skhamis/bump-version-21-2
Browse files Browse the repository at this point in the history 
Change strict_min_version to not include 0a1
  • Loading branch information
@skhamis
skhamis authored Jun 13, 2023
2 parents dee1c81 + 092802d commit 428a57e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
11 changes: 6 additions & 5 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,16 @@ The general process followed by the addons team is
but at the current time, the maintainers of about-sync don't have the required
permissions. Therefore, the process is:

* Consider bumping the version in `package.json` - that's not strictly necessary
as the final version string will be something like `X.Y.Zbuildid20220601.073719`,
but it makes it easier to work out what's in a version.
* Bump the version in `package.json`
> the final version string will be something like `X.Y.Zbuildid20220601.073719`
* If needed, bump the `strict_min_version` in `manifest.json`. Ensure there is a matching version you're targeting in the [version list](https://addons.mozilla.org/api/v5/applications/firefox/)
> Must use an exact version, `{version_number}.*` are not allowed to be used
* Find the exact github revision revision you want as the new build; usually current `main`.
Ensure this revision is tested using the [testing process described above](#testing-a-xpi)

* Join the #addons-pipeline slack channel, asking for a release to be built
specifying that exact revision.
* Follow the [Mozilla Add-on Review Request Intake](https://mozilla-hub.atlassian.net/wiki/spaces/FDPDT/pages/10617933/Mozilla+Add-on+Review+Requests+Intake) instructions to create an issue that will kick off the process for an update.

* You will be notified of an initial build, with will include a "dep-signing"
task - however, this doesn't create the .xpi you can submit to AMO. Two
Expand Down
2 changes: 1 addition & 1 deletion manifest.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"applications": {
"gecko": {
"id": "aboutsync@mhammond.github.com",
"strict_min_version": "114.0a1"
"strict_min_version": "114.0"
}
},

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "aboutsync",
"private": true,
"version": "0.21.1",
"version": "0.21.2",
"description": "About Sync Firefox addon",
"scripts": {
"build": "webpack --mode=production && web-ext build",
Expand Down

1 comment on commit 428a57e

@firefoxci-taskcluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error! Details

Taskcluster-GitHub attempted to create a task for this event with the following scopes:

["assume:repo:github.com/mozilla-extensions/aboutsync:tag:0.21.2-build1","queue:route:checks","queue:scheduler-id:taskcluster-github"]

The expansion of these scopes is not sufficient to create the task, leading to the following:

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

assume:repo:github.com/mozilla-extensions/aboutsync:branch:0.21.2-build1

This request requires the client to satisfy the following scope expression:

{
  "AllOf": [
    "assume:repo:github.com/mozilla-extensions/aboutsync:branch:0.21.2-build1",
    "queue:route:checks",
    "queue:route:index.xpi.v2.aboutsync.revision.428a57e0783c3527cfbc72989674dd9d821fb9b4.taskgraph.decision",
    "queue:create-task:project:none",
    "queue:scheduler-id:xpi-level-1",
    {
      "AnyOf": [
        "queue:create-task:highest:xpi-1/decision-gcp",
        "queue:create-task:very-high:xpi-1/decision-gcp",
        "queue:create-task:high:xpi-1/decision-gcp",
        "queue:create-task:medium:xpi-1/decision-gcp",
        "queue:create-task:low:xpi-1/decision-gcp",
        "queue:create-task:very-low:xpi-1/decision-gcp",
        "queue:create-task:lowest:xpi-1/decision-gcp"
      ]
    }
  ]
}
  • method: createTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-06-28T14:31:07.283Z

Please sign in to comment.