Fix #561: Synchronize waitlists to Acoustic #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
sync-waitlists
branch
2 times, most recently
from
178b835
to
4828663
Compare
leplatrem
added a commit
that referenced
this pull request
Jun 20, 2023
In this pull-request, I fix a piece of code that never worked: the newsletter subscription timestamps sent to Acoustic were never read from the database. Basically schemas do not read the timestamps fields from the DB. This could be a possible fix, but my confidence in its elegance is kind of low. This codebase has a really dark power of demotivation. Especially if you ever worked with tools like Django Rest Framework. Plus, most test case assertions are not designed in a flexible way.
leplatrem
force-pushed
the
sync-waitlists
branch
from
4828663
to
7c18c9a
Compare
These assertions are out of topic for this test. Remove them to avoid having to adjust them to the waitlist additions.
grahamalama
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #561
subscribed/unsub_reasonfields to waitlist #707Document upgrade prerequites (Acoustic instructions)https://mozilla-hub.atlassian.net/browse/CTMS-156