Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rise25 nomination page, link to honorees #14866

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

craigcook
Copy link
Member

One-line summary

Since nominations are long since closed and the honorees have been announced, the old nominate page was a bit confusing/misleading. This updates it to point to the winners site and remove the redundant portions.

This is in lieu of deleting the page entirely and redirecting the URL, at Rebecca's request.

Testing

http://localhost:8000/rise25/nominate/

@craigcook craigcook added Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.38%. Comparing base (5fd5d4f) to head (b849c03).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14866   +/-   ##
=======================================
  Coverage   77.38%   77.38%           
=======================================
  Files         161      161           
  Lines        8305     8306    +1     
=======================================
+ Hits         6427     6428    +1     
  Misses       1878     1878           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping at least some landing! Just a couple of housekeeping Qs:

</p>
</div>
{% if switch('rise25-nominations-open') %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan on removing the switch entirely from waffle config, or chances are next year will make use of it again so better to keep it there?;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can safely remove it from the config once this change has been deployed. Actually there are quite a few redundant switches that we can clean up. I have a work in progress to do that and I'll add this one to the list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The switch is already off which is basically the same as if it wasn't there at all.

Why I'm asking is I also keep track of what needs removing #14092 (comment) and some already removed waiting to clean up: mozmeao/www-config#559 that I'm slowly adding to;) Feel free to build on top of this if it helps…

Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc 🥞

bedrock/mozorg/urls.py Show resolved Hide resolved
@alexgibson alexgibson removed the Needs Review Awaiting code review label Jul 24, 2024
@craigcook craigcook merged commit 3d20b68 into mozilla:main Jul 24, 2024
5 checks passed
@craigcook craigcook deleted the rise25-update branch July 24, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants