-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rise25 nomination page, link to honorees #14866
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14866 +/- ##
=======================================
Coverage 77.38% 77.38%
=======================================
Files 161 161
Lines 8305 8306 +1
=======================================
+ Hits 6427 6428 +1
Misses 1878 1878 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping at least some landing! Just a couple of housekeeping Qs:
</p> | ||
</div> | ||
{% if switch('rise25-nominations-open') %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan on removing the switch entirely from waffle config, or chances are next year will make use of it again so better to keep it there?;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can safely remove it from the config once this change has been deployed. Actually there are quite a few redundant switches that we can clean up. I have a work in progress to do that and I'll add this one to the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The switch is already off which is basically the same as if it wasn't there at all.
Why I'm asking is I also keep track of what needs removing #14092 (comment) and some already removed waiting to clean up: mozmeao/www-config#559 that I'm slowly adding to;) Feel free to build on top of this if it helps…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc 🥞
One-line summary
Since nominations are long since closed and the honorees have been announced, the old nominate page was a bit confusing/misleading. This updates it to point to the winners site and remove the redundant portions.
This is in lieu of deleting the page entirely and redirecting the URL, at Rebecca's request.
Testing
http://localhost:8000/rise25/nominate/