Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate addresses in table onerep_profiles #5688

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flozia
Copy link
Collaborator

@flozia flozia commented Mar 6, 2025

References:

PR: #5660
Jira: MNTOR-4065

Description

Builds up on the migration file for PR #5660: Migrates city_name and state_code to the new column addresses.

How to test

  • Run npm run db:migrate: The table onerep_profiles should contain the applied changes.
  • Run npm run db:rollback: The table onerep_profiles should have its initial state.

@flozia flozia changed the title Mntor 4065 migrations addresses Migrate addresses in table onerep_profiles Mar 6, 2025
@flozia flozia self-assigned this Mar 6, 2025
@flozia flozia marked this pull request as draft March 6, 2025 13:12
@flozia flozia requested review from Vinnl and rhelmer March 6, 2025 13:12
@flozia flozia mentioned this pull request Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct, one thing to consider is that if you do use the rollback, it will only take the first address losing the others. We should try to avoid having to use it, but if we do that's something to consider. The only way this would matter is if we enable the feature for users before finding a serious issue that warrants rollback, so let's try not to do that e.g. testing carefully behind an allow-listed flag :)

Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is fine if we first update the existing UI to write to both fields, in which case we can still safely roll this back. As soon as we enable people to add multiple addresses, we can consider this migration completed and should no longer roll it back.

Base automatically changed from mntor-4065-migrations to main March 11, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants